Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Call super? Not necessary." is misleading - may affect mixins #1242

Open
jrencz opened this issue Oct 26, 2023 · 0 comments
Open

"Call super? Not necessary." is misleading - may affect mixins #1242

jrencz opened this issue Oct 26, 2023 · 0 comments

Comments

@jrencz
Copy link

jrencz commented Oct 26, 2023

In Article https://lit.dev/docs/components/lifecycle/#content next to most described lifecycle callbacks there's a "Call super? Not Necessary" info.

(and others like this one)

I think those are misleading - it's only true unless component uses mixins or if neither mixin in chain implements lifecycle callbacks, which If I understand

## Creating mixins for LitElement
Mixins applied to LitElement can implement or override any of the standard
[custom element lifecycle](/docs/v3/components/lifecycle/#custom-element-lifecycle)
callbacks like the `constructor()` or `connectedCallback()`, as well as any of
the [reactive update lifecycle](/docs/v3/components/lifecycle/#reactive-update-cycle)
callbacks like `render()` or `updated()`.

is OK for mixins to do.

Before I file a PR to adjust I want to as for conformation if I understand the problem correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant