Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve top level Context example by adding html #1186

Open
AndrewJakubowicz opened this issue Sep 15, 2023 · 0 comments
Open

[docs] Improve top level Context example by adding html #1186

AndrewJakubowicz opened this issue Sep 15, 2023 · 0 comments

Comments

@AndrewJakubowicz
Copy link
Contributor

AndrewJakubowicz commented Sep 15, 2023

It's not clear in the first Context example that the provider should be a parent of the consumer.

This results in a first experience where it's unclear how to arrange the producing and consuming elements. E.g., Placing the elements as siblings does not result in context being shared.

  <my-app></my-app>
  <my-element></my-element>

Instead, my-element (the consumer) must be a descendent of my-app. So the following works:

<my-app>
  <my-element></my-element>
</my-app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant