Skip to content

Update README.md #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Update README.md #97

merged 1 commit into from
Jun 24, 2020

Conversation

ATGardner
Copy link
Contributor

made changes requested in PR #91
removed usage of whitelist

Just figured I can make a PR, since I saw you requesting it on Twitter right now.

Description

Replaced the bullet of the --allowed-schemes to match the updated phrasing. I also noticed there was a use of whitelist, so I replaced it with list, which seems simpler and more fitting.

Types of changes

Only changed the readme file

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#89

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
made changes requested in PR #91 
removed usage of whitelist
@codecov-commenter
Copy link

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          11       11           
  Lines         237      237           
  Branches       41       41           
=======================================
  Hits          236      236           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0914b6...82aa800. Read the comment docs.

@lirantal lirantal self-requested a review June 24, 2020 20:07
@lirantal lirantal added the documentation Improvements or additions to documentation label Jun 24, 2020
@lirantal
Copy link
Owner

Wonderful! thanks bunch 🤗

@lirantal lirantal merged commit e763b99 into lirantal:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants