Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation success console message #87

Merged

Conversation

bolatovumar
Copy link
Contributor

Adds validation success message.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Close #76

Motivation and Context

Informs the user that everything is good so the user is not left wondering if the validation actually ran successfully.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Screen Shot 2020-03-28 at 4 05 51 PM

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@codecov-io
Copy link

Codecov Report

Merging #87 into master will increase coverage by 2.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   96.87%   99.56%   +2.69%     
==========================================
  Files          11       11              
  Lines         192      230      +38     
  Branches       31       40       +9     
==========================================
+ Hits          186      229      +43     
+ Misses          5        1       -4     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
packages/lockfile-lint/src/main.js 95.65% <0.00%> (ø)
packages/lockfile-lint-api/index.js 100.00% <0.00%> (ø)
packages/lockfile-lint/src/validators/index.js 100.00% <0.00%> (ø)
...s/lockfile-lint-api/src/validators/ValidateHost.js 100.00% <0.00%> (ø)
...kages/lockfile-lint-api/src/common/PackageError.js
...es/lockfile-lint-api/src/validators/ValidateUrl.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b481e80...dbb8321. Read the comment docs.

Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lirantal
Copy link
Owner

Good stuff, thanks @bolatovumar

@lirantal lirantal merged commit 3ff6eb8 into lirantal:master Mar 31, 2020
@bolatovumar bolatovumar deleted the add-validation-success-message branch April 11, 2020 18:14
@XhmikosR
Copy link
Contributor

FYI the emojis don't work on Windows default cmd @lirantal

@lirantal
Copy link
Owner

Thanks @XhmikosR. what does it look like?

@XhmikosR
Copy link
Contributor

ll

@lirantal
Copy link
Owner

Gotcha.
Feel like PRing a small one to remove the emoji?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "all is good" confirmation when validation succeeds
4 participants