Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DB2 LUW supports boolean data type #966

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Conversation

regrog
Copy link
Contributor

@regrog regrog commented Jan 15, 2020

In my last PR #865 I forgot a line of code to activate the boolean support.

Test Requirements

  • Do a desk check with the developer
  • Verify unit or integration tests exist.

┆Issue is synchronized with this Jira Bug by Unito
┆fixVersions: Community 4.3.0,Liquibase 4.3.0

@datical-jenkins datical-jenkins changed the title fix DB2 LUW supports boolean data type LB-28 ⁃ fix DB2 LUW supports boolean data type Mar 4, 2020
@datical-jenkins datical-jenkins changed the title LB-28 ⁃ fix DB2 LUW supports boolean data type fix DB2 LUW supports boolean data type Mar 5, 2020
@regrog
Copy link
Contributor Author

regrog commented Apr 9, 2020

Any news about this?

@ro-rah
Copy link

ro-rah commented Apr 10, 2020

Hi @regrog,

So sorry for the delay, I am taking a look at this. Please bear with us as we streamline our internal processes.

-Ronak

@ro-rah ro-rah added the RiskLow Trivial changes in spelling, documentation changes, focused bug fixes, etc. label Apr 10, 2020
@ro-rah
Copy link

ro-rah commented Apr 10, 2020

Tagging as RiskLow because:

  • no conflicts w/ base branch
  • the change just look like the user is allowing DB2 LUW boolean type which code could not run due to conditional blocking: if ((database instanceof AbstractDb2Database) || (database instanceof FirebirdDatabase)) {

@ro-rah
Copy link

ro-rah commented Apr 10, 2020

@regrog, slating this for the next sprint and targeting release before end of Q2. Thanks for your patience!

@datical-jenkins datical-jenkins added RiskMedium Changes that require more testing or that affect many different code paths. and removed RiskLow Trivial changes in spelling, documentation changes, focused bug fixes, etc. labels Apr 14, 2020
@liquibot
Copy link
Contributor

➤ Erzsebet Carmean commented:

Can Community Engagement please clarify if this ticket is correctly labeled as RiskMedium? I see a comment that it is RiskLow but the actual categorization is different. If the ticket is correctly risked as Medium, would this fall to Low if a unit test is added?

@ro-rah
Copy link

ro-rah commented Apr 27, 2020

Hi Erzsabet, my vote is yes that would turn this into a Risk Low.

@liquibot
Copy link
Contributor

➤ Erzsebet Carmean commented:

I've added test time for one hour to go over tests and do a desk check with development. Thanks for clarifying, Ronak.

@regrog
Copy link
Contributor Author

regrog commented Sep 11, 2020

Any plan to merge this?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBDB2LUW IntegrationAny RiskMedium Changes that require more testing or that affect many different code paths. ThemeDBObjects TypeBug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants