Modify SetColumnRemarks support for mysql. The original code does not support mysql modification notes #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. Can you please edit it so that all the comments are in English? |
zyzyzy523
changed the title
|
Thanks for the update! |
nvoxland
suggested changes
Dec 27, 2019
liquibase-core/src/main/resources/www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.8.xsd
Outdated
Show resolved
Hide resolved
datical-jenkins
changed the title
datical-jenkins
changed the title
# Conflicts: # liquibase-core/src/main/java/liquibase/sqlgenerator/core/SetColumnRemarksGenerator.java
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
=========================================
Coverage 47.71% 47.72%
- Complexity 7477 7482 +5
=========================================
Files 757 757
Lines 36278 36302 +24
Branches 6624 6628 +4
=========================================
+ Hits 17311 17326 +15
- Misses 16660 16666 +6
- Partials 2307 2310 +3
Continue to review full report at Codecov.
|
|
Hi @zyzyzy523 , Thanks for your PR submission. Its been awhile since we heard from you. Did you need any help or further guidance around the changes @nvoxland requested? Thanks! Ronak |
|
@zyzyzy523 I will move this into Conditioning but size it RiskMed. Eng time will be needed to make the change requested by @nvoxland. Thanks for including tests and translations! |
ro-rah
added
RiskMedium
This was referenced Apr 13, 2021
This was referenced Apr 22, 2021
php-coder
added a commit
to php-coder/mystamps
that referenced
this pull request
Sep 8, 2022
…instead of the tables) comments In the commit 89ba68c (#1326) I used <setColumnRemarks> in order to put comments to the fields. It has turned out that on MySQL, Liquibase put comments on the tables instead of the fields (see liquibase/liquibase#942). After update of Liquibase (#1526), it became possible to fix the bug on our data. Fix #1408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the sql statement generated by setColumnRemarks of the mysql database is ALTER TABLE cat.person COMMENT = 'A String';
Now modify it to ALTER TABLE cat.person MODIFY COLUMN id int COMMENT 'A String';