[V4.25.0] CreateViewGenerator issue

[adamjones0101]

Search first

• I searched and no similar issues were found

Description

CreateViewGenerator.generateSql is not creating the correct SQL when isFullDefinition is false and replaceIfExists is true.

Code should read something like this around line 81:

.prepend("VIEW")
.prepend(" ");
if (statement.isReplaceIfExists()) {
viewDefinition.prepend("CREATE OR REPLACE");
}
else {
viewDefinition.prepend("CREATE");
}

Steps To Reproduce

use fullDefinition false and replaceIfExists true on a view that exists

Expected/Desired Behavior

SQL should be CREATE OR REPLACE

Liquibase Version

4.25.0

Database Vendor & Version

Oracle 19.3

Liquibase Integration

No response

Liquibase Extensions

No response

OS and/or Infrastructure Type/Provider

No response

Additional Context

Oracle 19.3

Are you willing to submit a PR?

• I'm willing to submit a PR (Thank you!)

[kevin-atx]

@adamjones0101 - thank you for this issue. Since you already identified the code that would need to change, would you be willing to submit the change as a PR?

[adamjones0101]

I could. I had to make a little more change to CreateViewGenerator.java to get it to work right. However, I have not been able to fully test our changesets because of #5359 which is a serious regression. Therefore I hesitate to submit the PR at this time.

[adamjones0101]

I do not have a Git environment from which I can create a PR, I only download the zip, build it and use it within our product.
However, I am attaching my changed file for anybody to review and push
CreateViewGenerator.zip

[MalloD12]

Hi @adamjones0101,

I think this issue could have already been fixed by #5304. Would you mind trying on the latest liquibase version?

Thanks,
Daniel.

[adamjones0101]

It's not a high priority because we are still blocked by Issue 5359. In fact we are considering using Version 4.15.0 with the hope that the issue had not yet been introduced.

[MalloD12]

If it becomes something required to fix, could you please expand a little bit more on the steps performed to reproduce this issue? Which command were you trying to execute when you faced this issue, changelog example, etc? If you were trying to execute a generate-changelog or diff command I would recommend you to try with latest version when you have some time.

Thanks,
Daniel.