Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Use PathHandler for writing log files #3420

Merged
merged 1 commit into from Oct 31, 2022
Merged

Revert Use PathHandler for writing log files #3420

merged 1 commit into from Oct 31, 2022

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Oct 27, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Revert Use PathHandler for writing log files, which allows using S3 and other extensions (DAT-11515) (#3387)
This reverts commit 4d1bb4d.

Things to be aware of

Things to worry about

Additional Context

Add any other context about the problem here.

@abrackx
Revert "Use PathHandler for writing log files, which allows using S3 …
591c4f7 
…and other extensions (DAT-11515) (#3387)"

This reverts commit 4d1bb4d.
@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited

Unit Test Results

  4 668 files  ±0    4 668 suites  ±0   35m 55s ⏱️ -31s
  4 624 tests ±0    4 395 ✔️ ±0     229 💤 ±0  0 ❌ ±0 
54 696 runs  ±0  49 628 ✔️ ±0  5 068 💤 ±0  0 ❌ ±0 

Results for commit 591c4f7. ± Comparison against base commit 4d1bb4d.

♻️ This comment has been updated with latest results.

@abrackx abrackx marked this pull request as ready for review October 27, 2022 17:39
@abrackx abrackx merged commit 9949ca0 into master Oct 31, 2022
@abrackx abrackx deleted the revert-11515 branch October 31, 2022 17:51
abrackx added a commit that referenced this pull request Nov 3, 2022
@abrackx
Revert "Revert Use PathHandler for writing log files (#3420)"
efa4da6 
This reverts commit 9949ca0.
abrackx added a commit that referenced this pull request Nov 3, 2022
@abrackx
Use PathHandler for writing log files, which allows using S3 and othe…
8305293 
…r extensions (DAT-11515) (#3438)

Revert "Revert Use PathHandler for writing log files (#3420)"

This reverts commit 9949ca0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abrackx @nvoxland