Upgrade hsqldb from 2.5.2 to 2.7.1 #3400
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps hsqldb from 2.5.2 to 2.7.1. --- updated-dependencies: - dependency-name: org.hsqldb:hsqldb dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
…w requires java 11.
…ail for java 8. Adds a fallback loading strategy.
|
@FBurguer, hello! When we upgrade drivers, we do not usually do any manual testing. However, given that this fix is Java-version specific, I suggest we do some light manual testing.
@filipelautert is a good resource if you have any specific questions. |
nvoxland
changed the title
There was a problem hiding this comment.
I didn't see a spot where it lets users know that the driver they are trying to use is not compatible with java 8.
We probably can't / shouldn't have it be hsql-specific, since it can be a general error people as they manage their own drivers. They can even currently have it set up where they have drivers that require java 17 but they are on java 11 so can't just blame it on java 8.
So more like sending to both the UI service and severe-level logging Your database driver is not compatible with your version of Java. You will need to either upgrade your Java version or install a different driver jar file.
Otherwise the changes all look good
|
Hi @FBurguer @XDelphiGrl
|
…not compatible with the java version it's being executed.
|
For this PR I checked if this build worked with different Java versions, like Erz and Filipe suggested, these are the results:
-With Java 11, liquibase does an update and drop-all without problems: |
Bumps hsqldb from 2.5.2 to 2.7.1. As hsqldb now depends on Java 11, some changes had to be done to testing code:
liquibase-integration tests relied on hsqldb to run command line tests. Replaced it by h2, moved tests changelog files to h2 directory and fixed some tests that failed on h2 (mainly because of h2 requirements of not null columns for fks);
hsqldb was defined on liquibase.sdk.yaml as a test system database. Added logic to remove it on java 8
added code to skip hsqldb db test on java 8.
Fixes #3353
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)