Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End delimiter logic broken by BEGIN TRANSACTION #3356

Closed
nvoxland opened this issue Oct 10, 2022 · 6 comments
Closed

End delimiter logic broken by BEGIN TRANSACTION #3356

nvoxland opened this issue Oct 10, 2022 · 6 comments
Assignees
Labels

Comments

@nvoxland
Copy link
Contributor

Description

As reported in https://forum.liquibase.org/t/sql-scripts-with-multiple-go-statement-no-longer-working/7343/6 if you have BEGIN TRANSACTION then COMMIT, the end delimiters within them are not respected.

Steps To Reproduce

Create a changeset like:

BEGIN TRANSACTION;  
DELETE FROM HumanResources.JobCandidate  
    WHERE JobCandidateID = 13;  
COMMIT;  
@gsolecki
Copy link

Hi, I ran into the same problem, is there any temporary workaround?

@nvoxland
Copy link
Contributor Author

If you set an explicit endDelimeter you can control where the splitting happens. Like endDelimiter="" or endDelimiter="$$" if there are 's in the body of your SQL otherwise.

@bvikhanskiy
Copy link

I use the solution of xvc from here:
https://forum.liquibase.org/t/sql-scripts-with-multiple-go-statement-no-longer-working/7343/6
"We downgraded to 4.14.0 and everything works."

This seems to be the only version that works for me.

@PasupuletiRohini
Copy link

Hi, we are also blocked by this issue, and we are not able to upgrade to the latest liquibase versions. Is this issue going to be picked up soon?

@dozsa
Copy link

dozsa commented Mar 31, 2023

Seems this was caused by the changes done in #1589

@MalloD12
Copy link
Contributor

MalloD12 commented Apr 5, 2024

I've tested this one with the provided changelog (see issue description) and it seems it was fixed some time ago with #4099. As part of #5756 I added a test to validate this issue.

Thanks,
Daniel.

@MalloD12 MalloD12 closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

8 participants