Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix columnNames snapshot attribute of uniqueConstraints for Snowflake #3123

Merged
merged 2 commits into from Aug 2, 2022

Conversation

yodzhubeiskyi
Copy link
Contributor

@yodzhubeiskyi yodzhubeiskyi commented Jul 28, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

INFORMATION_SCHEMA in Snowflake doesn’t track ‘column_name’ attribute for constraints. As result, uniqueConstraints snapshot and changesets produced from diff/generate-changelog commands contain columnNames=”” attribute which results in Error during following update command. Currently the best workaround to get column_name for constraint is to use SHOW UNIQUE KEYS command followed by result_scan(last_query_id()) function.

@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Jul 28, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   37m 22s ⏱️ -52s
  4 594 tests ±0    4 379 ✔️ +4     215 💤  - 4  0 ±0 
54 300 runs  ±0  49 280 ✔️ +4  5 020 💤  - 4  0 ±0 

Results for commit 40e5ab6. ± Comparison against base commit 95a3a94.

♻️ This comment has been updated with latest results.

@yodzhubeiskyi yodzhubeiskyi changed the title DAT-11181 Workaround to retrieve columnNames for uniqueConstraints in… Fix columnNames snapshot attribute of uniqueConstraints for Snowflake Aug 2, 2022
@yodzhubeiskyi yodzhubeiskyi merged commit 9c3666a into master Aug 2, 2022
Conditioning++ automation moved this from To Do to Done Aug 2, 2022
@kristyldatical kristyldatical deleted the DAT-11181 branch August 2, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants