Improve failure message of RowCountPrecondition to preserve expected row count #3093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
The existing failure message for
RowCountPrecondition
will always tell Table [NAME] is not empty., even if there is an expected row count greater than zero.E.g. you set
expectedRows
to 5 and your table has 10 rows, you'll get the following failure message, which is somehow misleading, because you do not expect to have an empty table at all:Table [NAME] is not empty.
The change updates the error message to be more specific and contain the
expectedRows
:Table [NAME] does not have the expected row count of 5.
Things to worry about
getFailureMessage
, so classes extending fromRowCountPrecondition
may in fact break if they did override this method.