Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed DatabaseInfoAttributes in XSD #2239

Merged
merged 4 commits into from Jul 28, 2022
Merged

Conversation

kazz62
Copy link
Contributor

@kazz62 kazz62 commented Nov 29, 2021

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Removed the unused DatabaseInfoAttributes definition in the XSD

@nvoxland
Copy link
Contributor

nvoxland commented Jul 19, 2022

@kazz62 thanks for the PR, but the git changes ended up not quite right:

  • It is creating new copies of the xsd files in the root of the repo vs. updating the existing ones in www.liquibase.org/xml/ns/dbchangelog/
  • We can't updated published xsd files because that causes differences in versions between all the places they get stored and cached. Instead, simply update the dbchangelog-latest.xsd file and that will get rolled into the next version's XSD.

I updated your branch based on what I think you meant (it also ended up bringing your repo up to date with master). Did I get that correct?

@nvoxland nvoxland changed the base branch from master to 1_9 July 19, 2022 19:17
@nvoxland nvoxland changed the base branch from 1_9 to master July 19, 2022 19:18
@nvoxland nvoxland added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jul 19, 2022
@github-actions
Copy link

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   38m 12s ⏱️ + 1m 41s
  4 589 tests ±0    4 375 ✔️ ±0     214 💤 ±0  0 ±0 
54 240 runs  ±0  49 232 ✔️ ±0  5 008 💤 ±0  0 ±0 

Results for commit ac013f6. ± Comparison against base commit 83faa21.

@kataggart kataggart requested review from nvoxland and removed request for kataggart July 20, 2022 13:47
@nvoxland
Copy link
Contributor

Code review and test results:

Things to be aware of:

  • Removes an old and unused block of attributes in the XSD
  • Just cleaning up dead code, not changing anything

Things to worry about:

  • Nothing

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix removes dead code from the XSD.
  • No additional testing required.

APPROVED

Passing Functional Tests
Passing Test Harness Execution

@nvoxland nvoxland merged commit 4b8ffe4 into liquibase:master Jul 28, 2022
Conditioning++ automation moved this from To Do to Done Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocandidate ignore-release-notes IntegrationMaven SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2022-30 TypeEnhancement XSD
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants