New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cacheSize of createSequence is ignored #2147
Comments
HI @mickroll Thanks for creating this issue and notifying us about it. We will add this to the list of issues that we are processing. If you have a PR with a fix for this, that would be great. |
A colleague of mine (@tkalmar) just wrote that he may have located the bug:
-->MariaDB is ignored here Btw.
Same goes for AlterSequence: https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java#L75 |
Having the first deeper look at this repository, I have a bit of a hard time reading and understanding this part of the code, but shouldn't polling |
It may be better to have more function checks like that vs instanceof. The trouble is that there is sort of an unlimited variation in what features are supported and not supported across the databases and also we hit variations in the SQL to generate depending on the database as well. We're looking at some refactoring to make that all work better, but it's a medium-term project. In the meantime, I opened a PR that handles it the current way. |
Thank you! |
Environment
Liquibase Version: 4.4.3
Liquibase Integration & Version: quarkus 2.3.0.Final
Liquibase Extension(s) & Version: liquibase-core only
Database Vendor & Version: MariaDB 10.6.4
Operating System Type & Version: Windows 10
Description
The Attribute
cacheSize
ofcreateSequence
seems to be ignored.Steps To Reproduce
Run the following changesets:
working
shows the wanted end resultattribute
shows usage ofcreateSequence cacheSize
(which will be ignored)default
shows the default value ofcacheSize
(as defined by the database, i guess)Now run the following SQL on the database to extract the results (or view the created sequences in the db client of our choice):
Actual Behavior
working = 5
(as expected)set with attribute = 1000
(bug)default = 1000
(shows default value)Expected/Desired Behavior
set with attribute = 5
(as defined by the attributecacheSize
ofcreateSequence
tag)Screenshots (if appropriate)
Additional Context
Doesn't work, either:
<alterSequence sequenceName="SEQ_SET" cacheSize="5"/>
┆Issue is synchronized with this Jira Story by Unito
The text was updated successfully, but these errors were encountered: