Update Derby reserved words #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated DerbyDatabase definition to use the set of keywords defined in https://db.apache.org/derby/docs/10.2/ref/rrefkeywords29722.html resolves liquibase#1031
|
Hi @andrewhj Thanks for creating this PR. A member of the Liquibase team will take a look at your contribution and may suggest:
The PR will be prioritized according to our internal development and testing capacity. We’ll let you know when it’s ready to move to the next step or if any changes are needed. |
molivasdat
added
DBApacheDerby
ImpactLow
IntegrationSpringboot
RiskMedium
nvoxland
added
the
SafeToBuild
|
Code review and test results: Things to be aware of:
Things to worry about:
|
nvoxland
approved these changes
Jul 18, 2022
XDelphiGrl
reviewed
Jul 20, 2022
suryaaki2
approved these changes
Jul 21, 2022
XDelphiGrl
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
- PR introduces a revised list of Derby reserved keywords used by Liquibase to determine quoting of generated Derby SQL.
- Source of keywords is the Derby Documentation.
- Existing tests updated to reflect changes in keyword quoting.
- No additional testing required.
APPROVED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Liquibase Version: master
Liquibase Integration & Version: spring boot
Liquibase Extension(s) & Version:
Database Vendor & Version: Derby
Operating System Type & Version: Windows 10
Pull Request Type
Description
Updated DerbyDatabase definition to use the set of keywords defined in
https://db.apache.org/derby/docs/10.2/ref/rrefkeywords29722.html
Fixes #1031
Steps To Reproduce
define a changeset using a reserved word from the SQL-92 spec (such as action or state)
generate sql or migrate
table name should be standard but in this case would be "quoted"
the VerifyChangeClassesTest and modified derby.sql (included in the PR) perfectly illustrates the change.
Actual Behavior
generates sql like the following:
Expected/Desired Behavior
it should generate sql like:
which should make sql statements less picky about case, which will also make it work better with tools like JPA or DBUnit.