DiffChangeLog/GenerateChangeLog produces invalid XML in 4.3.3

[nvoxland]

Environment

Liquibase Version: 4.3.3

Database Vendor & Version: Postgresql for sure, probably all

Description

When running diffChangelog or generateChangelog, addColumn elements are added BEFORE corresponding createTable elements.

Steps to Reproduce

1. Create a database with:

<changeSet author="author_name" id="1">
        <createTable tableName="baseInfo">
            <column name="id" type="INTEGER">
                <constraints nullable="false" primaryKey="true" primaryKeyName="baseInfo_pkey"/>
            </column>
            <column name="first" type="VARCHAR(150)"/>
            <column name="middle" type="VARCHAR(150)"/>
            <column name="last" type="VARCHAR(150)"/>
        </createTable>
    </changeSet>

1. Run “liquibase generateChangeLog”
2. Generated generated changelog looks like:

<changeSet author="Edi(generated)" id="1618486085348-1">
        <addColumn tableName="baseInfo">
            <column name="id" type="int4">
                <constraints nullable="false"/>
            </column>
        </addColumn>
    </changeSet>
    <changeSet author="Edi (generated)" id="1618486085348-2">
        <createTable tableName="baseInfo">
            <column name="id" type="INTEGER">
                <constraints nullable="false" primaryKey="true" primaryKeyName="baseInfo_pkey"/>
            </column>
            <column name="first" type="VARCHAR(150)"/>
            <column name="middle" type="VARCHAR(150)"/>
            <column name="last" type="VARCHAR(150)"/>
            <column name="RandomId" type="INTEGER"/>
        </createTable>
    </changeSet>

which fails “liquibase update” because the addColumn command should not be there.

[sync-by-unito]

➤ Pavlo Tytarchuk commented:

Verified with version 4.3.4 #54 . Moving to “Ready to Merge”.