Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for generateChangelog on DB2iSeries #152

Merged
merged 1 commit into from Sep 27, 2013
Merged

added support for generateChangelog on DB2iSeries #152

merged 1 commit into from Sep 27, 2013

Conversation

thomseno
Copy link
Contributor

@thomseno thomseno commented Aug 5, 2013

added DB2 for IBM i catalog tables to support sequences and unique contraints

@blankser
Copy link
Contributor

LOL, I've made the exact same changes and was about to commit them.
I actually made some more changes:
-/liquibase/sqlgenerator/core/FindForeignKeyConstraintsGeneratorDB2.java has some queries that are incompatable with DB2i. However, it seems that this is not used. Am I correct?

  • I noticed a problem with generating foreign keys. Some (well in my case most) of them aren't picked up. This is because the CatalogAndSchema object is filled with the db2 instance name as catalog, and the schema name as schema name.
    any way I modified DB2iDatabase as such to resolve it (also to ignore system views):
   @Override
    public String getJdbcSchemaName(CatalogAndSchema schema) {
        return schema.getSchemaName()!=null?schema.getSchemaName():schema.getCatalogName();
    }
    @Override
    public boolean isSystemObject(DatabaseObject example) {
        if (example == null) {
            return false;
        }

        if (example instanceof View && example.getName().startsWith("SYS")) {
            return true;
        }
        return false;
    }

@nvoxland nvoxland merged commit eb5b24e into liquibase:master Sep 27, 2013
@nvoxland
Copy link
Contributor

Merged changes into master for the 3.1.0 release. @blankser you are right that FindForeignKeyConstraintsGeneratorDB2 isn't used for DB2i, only for DB2.

I've made changes to how the foreign key detection works, can you try a new build from master and see if it is working better?

nvoxland added a commit that referenced this pull request Dec 18, 2019
filipelautert added a commit that referenced this pull request Apr 23, 2024
…picocli-4.7.4

Bump picocli from 4.7.3 to 4.7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants