Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Forbid @ as a username character #2677

Open
slomo opened this issue Sep 7, 2016 · 5 comments
Open

Forbid @ as a username character #2677

slomo opened this issue Sep 7, 2016 · 5 comments

Comments

@slomo
Copy link
Contributor

slomo commented Sep 7, 2016

Because the frontend uses the @ to check if email address or username has been given to the unified login dialog, the creation of users using @ as name should be denied, otherwise they can't login.

@joka
Copy link
Collaborator

joka commented Sep 8, 2016

Instead of restricting characters a more sophisticated email detection would be nicer.

@joka
Copy link
Collaborator

joka commented Sep 8, 2016

Also the backend instead of the frontend would be the better place to handle issues like "is this an email or login name"

@der-john der-john added backend and removed frontend labels Sep 8, 2016
@slomo
Copy link
Contributor Author

slomo commented Sep 8, 2016

I think if usernames are free text the most sophisticated email detection might not be able to tell apart user names from emails 😄, and on the other hand propper email detection is rally hard.

I agree with your second remark.

@joka
Copy link
Collaborator

joka commented Sep 8, 2016

I think if usernames are free text the most sophisticated email detection might not be able to tell apart user names from emails 😄, and on the other hand proper email detection is rally hard.

for perfect detection, True

@der-john
Copy link

Doesn't seem to bother anyone.

@der-john der-john reopened this Nov 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants