Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external URL support for hd-home config #13

Merged
merged 1 commit into from Jan 31, 2021

Conversation

LinuxSuRen
Copy link
Owner

No description provided.

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Jan 31, 2021
@linuxsuren-bot
Copy link
Collaborator

Welcome @LinuxSuRen! It looks like this is your first PR to LinuxSuRen/http-downloader 🎉

@LinuxSuRen
Copy link
Owner Author

/approve
/lgtm

@linuxsuren-bot
Copy link
Collaborator

@LinuxSuRen: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@LinuxSuRen
Copy link
Owner Author

/merge

@LinuxSuRen
Copy link
Owner Author

/approve

@linuxsuren-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LinuxSuRen
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LinuxSuRen
Copy link
Owner Author

/squash

@LinuxSuRen
Copy link
Owner Author

/shrug

@LinuxSuRen LinuxSuRen merged commit cb57b4a into master Jan 31, 2021
@LinuxSuRen LinuxSuRen deleted the support-external-url branch January 31, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ¯\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants