Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accessibility #673

Open
13 of 17 tasks
cjyabraham opened this issue Dec 9, 2021 · 11 comments
Open
13 of 17 tasks

Improve Accessibility #673

cjyabraham opened this issue Dec 9, 2021 · 11 comments
Assignees
Projects

Comments

@cjyabraham
Copy link
Collaborator

cjyabraham commented Dec 9, 2021

Current plan if for James/Chris to start improving the accessibility of the site. Once they've done what they can, we can discuss with Kristin/Angela about making a stronger commitment to accessibility for the site. If we get this we can move forward with publishing an Accessibility Statement, new requirements for incoming event designs/assets, and any further communications.

Improvements needed:

  • Enable sponsors to have alt text and for better title text on links on sponsor images in sponsor block
  • Add new field to sponsors "display name" that can override the sponsors name if needed
  • Install PublishPress Checklists plugin and set to require alt text for all images
  • Check social links in speaker block for accessibility issues
  • Update speakers images to have alt text
  • Fix accessibility of hamburger button
  • Add alt text to LF logo
  • Fix aria roles on speakers and footer
  • Fix accessibility issues with missing labels on the newsletter forms (note: this is also a problem on cncf.io)
  • Image box has empty link and no alt text on the image
  • Tables ("schedule at a glance") need column headers set for screen readers, optionally have a screen reader caption
  • Update menu to be controllable by keyboard and insert skip link
  • Made cookie colors less garish

After this initial work, we could follow up with the following:

  • Get buy-in from Angela/Kristin for being more public about our work
  • Publish a list of guidelines for Event authors so that they can design for accessibility from the outset and also so that Nicole can reference them when and Event design needs improving
  • Publish an Accessibility Statement, similar to that of CNCF, and link to it in the footer
  • Publicize our work on this and reasons for doing it when it’s done to build awareness within the team (see doc written for CNCF); possibly write a blog post to be published on the LF Events site
@cjyabraham cjyabraham added this to Triage in lfevents via automation Dec 9, 2021
@cjyabraham cjyabraham moved this from Triage to Later in lfevents Dec 9, 2021
@cjyabraham cjyabraham moved this from Later to Soon in lfevents Dec 9, 2021
@cjyabraham cjyabraham moved this from Soon to In progress in lfevents Mar 8, 2023
@cjyabraham cjyabraham self-assigned this Mar 8, 2023
cjyabraham added a commit that referenced this issue Mar 9, 2023
… logo to override value. (#673)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
thetwopct pushed a commit that referenced this issue Mar 14, 2023
… logo to override value. (#673)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
thetwopct pushed a commit that referenced this issue Mar 14, 2023
… logo to override value. (#673)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Copy link
Collaborator

@cjyabraham Could you have a look at Hubspot to see if we are able to fix the form label issues? I only have CSS control of the embed form it seems - it's inserted via short link:

echo do_shortcode( '[hubspot type=form]' );

@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Mar 14, 2023

I don't think I can omit the labels. One option, however, is we provide labels but hide them with our own CSS? Or we just skip this one...

@thetwopct
Copy link
Collaborator

Hubspot allows us to add a label for each form field. I've now added the CSS so that will be hidden (as per the design) and only read for screen readers. Once this PR is merged, we will have to update the footer form with the labels.

thetwopct pushed a commit that referenced this issue Mar 14, 2023
… logo to override value. (#673)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
thetwopct added a commit that referenced this issue Mar 14, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
thetwopct added a commit that referenced this issue Mar 14, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Copy link
Collaborator

Regarding the tables, I miss-remembered how they were made - I thought they were custom blocks already. But we are using default WordPress tables. This means:

  • There is already a caption option on them (I have styled it in the editor to be a bit more obvious, and hid it on the frontend as screen reader text).

Screenshot-2023-03-16 --00 04 55@2x

- There is already an option to add a header section. I think adding a header looks fine, so maybe the team can just start doing that? If not we need another solution TBD.

Screenshot-2023-03-15 --23 45 03@2x

thetwopct added a commit that referenced this issue Mar 15, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
thetwopct added a commit that referenced this issue Mar 15, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
thetwopct added a commit that referenced this issue Mar 15, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Copy link
Collaborator

@cjyabraham I've added skip link and made the global and event menu keyboard accessible. There's some weirdness with the other-event menu item at the end of the events menu, I can't get it to open, needs more investigation. Do you want to carry on with more things to fix or release this as is, update the hubspot forms, and then re-evaluate?

@cjyabraham
Copy link
Collaborator Author

Thanks. This sounds like a good stopping point for a release. I'll test it out and have Nicole do the same then we can release.

@cjyabraham
Copy link
Collaborator Author

When I run WAVE on this page it calls out the image boxes for having empty links. Is that fixable?

@thetwopct
Copy link
Collaborator

Have you edited the page and re-saved the block? It's JS so I don't think it will update on its own.

thetwopct added a commit that referenced this issue Mar 16, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham added a commit that referenced this issue Mar 27, 2023
… logo to override value. (#673)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham pushed a commit that referenced this issue Mar 27, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham pushed a commit that referenced this issue Mar 27, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham pushed a commit that referenced this issue Mar 27, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham pushed a commit that referenced this issue Mar 27, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham pushed a commit that referenced this issue Mar 27, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
cjyabraham pushed a commit that referenced this issue Mar 27, 2023
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Apr 5, 2023

  • Accessibility guidelines page (@thetwopct to draft); this needs to be published prior to emailing Angela
  • Message to Angela; get ahead of upstream brand (Nicole to draft; Chris/James/Kristin to review)

@thetwopct
Copy link
Collaborator

@cjyabraham Could you revisit this issue and let me know if there is any further action required?

@cjyabraham
Copy link
Collaborator Author

No action required at this point but let's keep this open for now since more work is planned and there are some good ideas here.

@cjyabraham cjyabraham moved this from In progress to Soon in lfevents Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Soon
lfevents
  
Soon
Development

No branches or pull requests

2 participants