Prettier --write command changed not only staged files.

[DonikaV]

I have monorepo with lerna. The setup is like here https://github.com/sudo-suhas/lint-staged-multi-pkg/blob/master/package.json

Steps to reproduce

In each folder i have this .linkstagedrc.yml with

linters:
  "src/main/js/**/*.{js,jsx,mjs}":
    - "prettier --write 'src/main/js/**/*.{js,jsx,mjs}'"
    - "git add"

The problem is - i modified only one js file. I do commit, and then in git i see much more files than one. But i want modify only staged file.
Can someone help me with that? Thanks.

Environment

• OS: Macos
• Node.js: current LTS (10*)
• lint-staged: latest

[borwahs]

I am running into the same issue with the following in package.json:

"lint-staged": {
    "*.{js,jsx,css}": [
      "prettier --write",
      "git add"
    ]
  },

I am not using lerna though.

[borwahs]

Disregard my comment. My issue was that our lint-staged was actually an older version which doesn't have #75 (fixing #62) in it.

[okonet]

@DonikaV your issue is with the config you're using. You pass glob as an argument and that's why prettier runs on all matching files. Instead, remove the glob from arguments since that's exactly what lint-staged is doing for you under the hood.

[DonikaV]

@okonet can you help me and say what exactly i should change? Thanks in advance.
Because backend guys complain about my improvements for frontend :D They dont want see this precommit hook been executed on his machines.

[okonet]

@DonikaV I thought I did:

Instead, remove the glob from arguments since that's exactly what lint-staged is doing for you under the hood.

You should change it to this:

linters:
  "src/main/js/**/*.{js,jsx,mjs}":
-    - "prettier --write 'src/main/js/**/*.{js,jsx,mjs}'"
+    - "prettier --write"
    - "git add"

[DonikaV]

@okonet Thanks! Will try tomorrow.

[DonikaV]

@okonet works good! Thanks again!
Last question, can i somehow check if npm installed, if yes => run this hook, if not => skip?

[okonet]

Not sure what you mean but I remember there is a package that allows not running recommit hooks based on user's settings. I can't find it though :-(

[DonikaV]

@okonet I mean, backend guys are to lazy and they don’t want run npm install. :D
Ok, I will try to find something in google :)