New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bailing on failure when running concurrently should also work with vscode's WSL extension #1123
Comments
After the latest minor update in pidtree, we could bump the required version of pidtree to |
@iiroj I would like to note that ever since I realized that my initial implementation was flawed (I'm deeply sorry about that!), I tried to improve it in ways that @lildeadprince mentioned here (using events instead of polling): #1138 I found a simpler, more reliable solution relatively quickly and you can see it here: https://github.com/s-h-a-d-o-w/lint-staged/blob/chore/improve-task-killing-reliability/lib/resolveTaskFn.js I haven't been able to submit a PR though because as you can see on that branch, odd problems with some tests where multiple tests seem to share state appear. (In But I thought I should share it here and now regardless, since the changes in |
@s-h-a-d-o-w thanks, I will take a look at the |
@s-h-a-d-o-w I added a commit to #1173 that replaces |
Awesome, thanks for incorporating those improvements! |
Description
This is related to my previous work in #1117.
Currently, this doesn't work because of an old flaw in vscode. It fails pretty gracefully though - it just can't interrupt other running tasks and prints the error caused by WSL. A lot like the previous behavior.
I've submitted an issue to the vscode team but... let's see whether they are interested in fixing this.
I would argue to hold on to hope for a week or two before considering other options (I do have some backup plans 😅), if that's alright with you.
Steps to reproduce
Environment
lint-staged
: 12.3.6The text was updated successfully, but these errors were encountered: