From f570d60ee38f90710f9b6e3cf7c3da79507b4cc5 Mon Sep 17 00:00:00 2001 From: Andrey Okonetchnikov Date: Sun, 28 Oct 2018 18:23:20 +0100 Subject: [PATCH] reafctor: Remove impossible case handling from makeErr --- src/resolveTaskFn.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/resolveTaskFn.js b/src/resolveTaskFn.js index fe163a288..49d3dd5ab 100644 --- a/src/resolveTaskFn.js +++ b/src/resolveTaskFn.js @@ -65,21 +65,15 @@ function throwError(message) { function makeErr(linter, result, context = {}) { // Indicate that some linter will fail so we don't update the index with formatting changes context.hasErrors = true // eslint-disable-line no-param-reassign - const { stdout, stderr, failed, killed, signal } = result - if (failed) { - return throwError(dedent`${symbols.error} ${chalk.redBright( - `${linter} found some errors. Please fix them and try committing again.` - )} - ${stdout} - ${stderr} - `) - } + const { stdout, stderr, killed, signal } = result if (killed || (signal && signal !== '')) { return throwError( `${symbols.warning} ${chalk.yellow(`${linter} was terminated with ${signal}`)}` ) } - return throwError(dedent`${symbols.error} ${chalk.redBright('Unexpected error occured')} + return throwError(dedent`${symbols.error} ${chalk.redBright( + `${linter} found some errors. Please fix them and try committing again.` + )} ${stdout} ${stderr} `)