Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0071: Potential segfault in the time crate #7635

Closed
github-actions bot opened this issue Jan 19, 2022 · 1 comment · Fixed by #7776
Closed

RUSTSEC-2020-0071: Potential segfault in the time crate #7635

github-actions bot opened this issue Jan 19, 2022 · 1 comment · Fixed by #7776

Comments

@github-actions
Copy link

Potential segfault in the time crate

Details
Package time
Version 0.1.44
URL time-rs/time#293
Date 2020-11-18
Patched versions >=0.2.23
Unaffected versions =0.2.0,=0.2.1,=0.2.2,=0.2.3,=0.2.4,=0.2.5,=0.2.6

Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

The affected functions from time 0.2.7 through 0.2.22 are:

  • time::UtcOffset::local_offset_at
  • time::UtcOffset::try_local_offset_at
  • time::UtcOffset::current_local_offset
  • time::UtcOffset::try_current_local_offset
  • time::OffsetDateTime::now_local
  • time::OffsetDateTime::try_now_local

The affected functions in time 0.1 (all versions) are:

  • at
  • at_utc
  • now

Non-Unix targets (including Windows and wasm) are unaffected.

Patches

Pending a proper fix, the internal method that determines the local offset has been modified to always return None on the affected operating systems. This has the effect of returning an Err on the try_* methods and UTC on the non-try_* methods.

Users and library authors with time in their dependency tree should perform cargo update, which will pull in the updated, unaffected code.

Users of time 0.1 do not have a patch and should upgrade to an unaffected version: time 0.2.23 or greater or the 0.3 series.

Workarounds

No workarounds are known.

References

time-rs/time#293

See advisory page for additional details.

@olix0r
Copy link
Member

olix0r commented Jan 19, 2022

Waiting on resolution of kube-rs/kube#650 kube-rs/kube#656

As far as we understand, this does not describe an exploitable vulnerability in Linkerd's runtime artifacts, as we don't expose any means to alter these environment variables at runtime.

olix0r added a commit that referenced this issue Feb 3, 2022
RUSTSEC-2020-0071 no longer impacts this project thanks to `kube-rs`
changes.

Closes #7635
olix0r added a commit that referenced this issue Feb 3, 2022
RUSTSEC-2020-0071 no longer impacts this project thanks to `kube-rs`
changes.

Closes #7635
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant