Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep in a global cache the Wasm modules obtained by compiling a given bytecode #739

Closed
ma2bd opened this issue May 15, 2023 · 0 comments · Fixed by #762
Closed

Keep in a global cache the Wasm modules obtained by compiling a given bytecode #739

ma2bd opened this issue May 15, 2023 · 0 comments · Fixed by #762
Assignees
Labels
bug Something isn't working performance
Milestone

Comments

@ma2bd
Copy link
Contributor

ma2bd commented May 15, 2023

It seems that we're doing too much redundant (and concurrent) compilation. This might be the reason why we hit #633 while other Wasmer/singlepass users don't.

Possible definition for WasmApplication:

enum WasmApplication {
    Wasmer { contract_module: wasmer::Module, service_module: wasmer::Module },
    Wasmtime { contract_module: wasmtime::Module, service_module: wasmtime::Module },
}

For now, we should probably only allow one compilation tasks of a new bytecode at a given time. (I.e. I would just hold the module compilation cache under a lazy/mutex global variable.)

@ma2bd ma2bd added bug Something isn't working performance labels May 15, 2023
@ma2bd ma2bd added this to the Local testnet milestone May 15, 2023
@ma2bd ma2bd linked a pull request May 19, 2023 that will close this issue
@ma2bd ma2bd removed a link to a pull request May 19, 2023
@jvff jvff closed this as completed in #762 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants