We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractStreamDecoder
When running the failing tests in following pull request, I noticed that AbstractStreamDecoder#decode silently ignores the failure to decode messages.
AbstractStreamDecoder#decode
#5174 (review) https://github.com/line/armeria/actions/runs/6092788681/job/16531491206?pr=5174#step:9:3015
We are silently ignoring exceptions at this point:
armeria/core/src/main/java/com/linecorp/armeria/common/encoding/AbstractStreamDecoder.java
Lines 47 to 58 in 1c93fee
We probably want to let the caller know a decoding failure has been done instead of silently ignoring and returning an empty result.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
When running the failing tests in following pull request, I noticed that
AbstractStreamDecoder#decode
silently ignores the failure to decode messages.#5174 (review)
https://github.com/line/armeria/actions/runs/6092788681/job/16531491206?pr=5174#step:9:3015
We are silently ignoring exceptions at this point:
armeria/core/src/main/java/com/linecorp/armeria/common/encoding/AbstractStreamDecoder.java
Lines 47 to 58 in 1c93fee
We probably want to let the caller know a decoding failure has been done instead of silently ignoring and returning an empty result.
The text was updated successfully, but these errors were encountered: