Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade gRPC and protobuf dependencies #4666

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Feb 10, 2023

Motivation:

protocolbuffers/protobuf#11393

        Caused by:
        java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
            at com.google.protobuf.CodedOutputStream$UnsafeDirectNioEncoder.writeStringNoTag(CodedOutputStream.java:2153)
            at com.google.protobuf.CodedOutputStream$UnsafeDirectNioEncoder.writeString(CodedOutputStream.java:1922)
            at com.google.protobuf.GeneratedMessageV3.writeString(GeneratedMessageV3.java:3195)

Modifications:

  • Downgrade protobuf and gRPC

Result:

  • Users no longer encounter an exception when using protobuf, grpc with jre 8

@jrhee17 jrhee17 changed the title Downgrade grpc, proto Downgrade gRPC and protobuf dependencies Feb 10, 2023
@jrhee17 jrhee17 added this to the 1.22.1 milestone Feb 10, 2023
@jrhee17 jrhee17 added the defect label Feb 10, 2023
@jrhee17
Copy link
Contributor Author

jrhee17 commented Feb 10, 2023

Although I think this PR is ready, I would like to run the CI one more time after #4661 is merged 🙇

@jrhee17 jrhee17 marked this pull request as ready for review February 10, 2023 12:37
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ikhoon
Copy link
Contributor

ikhoon commented Feb 11, 2023

Re-ran the failed Java 8 test.

@jrhee17
Copy link
Contributor Author

jrhee17 commented Feb 13, 2023

It seems like gax-grpc was unintentionally resolving protobuf to a more recent version.
We may consider more stricter dependency resolution failure strategies (if there is an ability to limit to certain artifacts)

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@minwoox minwoox added this pull request to the merge queue Feb 13, 2023
Merged via the queue into line:master with commit 1278e70 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants