Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informational Notices UI: Color selection issue #169

Open
aaronware opened this issue Oct 9, 2020 · 3 comments
Open

Informational Notices UI: Color selection issue #169

aaronware opened this issue Oct 9, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aaronware
Copy link
Collaborator

When customizing the colors Informational Style Notices if you edit the styles, cancel then reopen the styles color selector inputs are all grey instead of their appropriate colors

@aaronware aaronware added the bug Something isn't working label Oct 9, 2020
@aaronware aaronware self-assigned this Oct 9, 2020
@aaronware aaronware added this to the 1.3.0 milestone Oct 9, 2020
@aaronware aaronware assigned maxinacube and unassigned aaronware Oct 9, 2020
@maxinacube
Copy link
Collaborator

@aaronware I pushed this update to issue/169 but it has not been merged to release/1.3.0 yet

One issue was if you opened a type to edit, then canceled it, and went back to the same type to edit all the colors were gray. For each color picker there is now a value set for "data-default-color" that fixes this.

One issue still remaining is when you save a notice type, the icon color is always gray until the page is refreshed. After a refresh the correct color shows. I debugged this for a while but have not found a solution yet.

@aaronware
Copy link
Collaborator Author

@maxinacube is that due to how the styles are on the ::before so it can't be applied "inline"?

@maxinacube
Copy link
Collaborator

@aaronware No sorry, when I refer to "the icon color is always gray" that is happening to me in the color picker after saving a notice type.

Before save: https://cldup.com/_eiNM3npzq.png
After save: https://cldup.com/4NouorLY4x.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants