Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change namespace due to wordpress.org conflict #126

Open
aaronware opened this issue May 16, 2020 · 6 comments
Open

change namespace due to wordpress.org conflict #126

aaronware opened this issue May 16, 2020 · 6 comments
Assignees
@maxinacube @fischfood @nate-allen

Comments

@aaronware
Copy link
Collaborator

No description provided.

@maxinacube
Copy link
Collaborator

Work done in the issue/126 branch

References for courier should now read courier notices

@maxinacube
Copy link
Collaborator

@maxinacube @fischfood -- Message from @aaronware to take note of:

I did notice some style issues possible due to class name changes (take a look at the type/designer area.)

@maxinacube
Copy link
Collaborator

maxinacube commented Jul 1, 2020 •
edited

Things to address:

  • Empty li bullets on the "Go Pro" tab
  • Broken image on the "About Courier" tab (@erroneous5000 do we have an image to use here?)
  • Need "callout" class removed from notices, causes funky display when Foundation CSS is present. "callout" class is not necessary for functionality or styles
  • Ajax method never loads in notices for header, footer, or modal
    • Tested on v1.2 of TwentyTwenty theme on WP v5.4.0, issue persists when updated to v1.4 of TwentyTwenty on WP v.5.4.2)
    • All containers are present in DOM but never populated
  • Non-ajax method never loads modal notice
    • Modal container is missing from DOM

maxinacube added a commit that referenced this issue Jul 2, 2020
@maxinacube
#126 Address QA items
dd55357 
Update notice style value to em vs. rem to better theme integration
Remove callout class to avoid clashing styles with Foundation themes
Remove empty bullets from the Go Pro details page
@maxinacube
Copy link
Collaborator

@erroneous5000 Here is a screenshot of the missing image I mentioned above

https://cldup.com/RyMH5t97uo.png

@aaronware
Copy link
Collaborator Author

@maxinacube what's left here?

@aaronware
Copy link
Collaborator Author

@maxinacube are these items still open?

maxinacube added a commit that referenced this issue Aug 17, 2020
@maxinacube
#126 Remove broken image from About tab
b4b06a7
aaronware added a commit that referenced this issue Aug 17, 2020
@aaronware
Merge pull request #154 from linchpin/issue/126-150
5e276c5 
#126 Remove broken image from About tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxinacube maxinacube

@fischfood fischfood

@nate-allen nate-allen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maxinacube @aaronware @fischfood @nate-allen