Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace timeouts with ctx #39

Open
jtagcat opened this issue Nov 7, 2023 · 1 comment
Open

Replace timeouts with ctx #39

jtagcat opened this issue Nov 7, 2023 · 1 comment

Comments

@jtagcat
Copy link

jtagcat commented Nov 7, 2023

https://pkg.go.dev/context

Functions should use ctx as argument. Context should be passed around (using DialContext instead of Dial), or checked with ctx.Done.

@likexian
Copy link
Owner

Hello @jtagcat
Thanks for your feedback, I will do it.


If you think this repository is helpful, please share it with friends, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants