Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filters] [Post Processors] Remove configurable post processor interface for one interface and cleanup filter manager #1075

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Mar 9, 2018

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This pull request removes ConfigurablePostProcessorInterface and instead adds an optional options array to the normal PostProcessorInterface interface. The new signiture for the post processor process method is:

public function process(BinaryInterface $binary, array $options = []): BinaryInterface;

Additionally, the FilterManager implementation has been cleaned up and reorganized, with (almost) the same functionality. The only change is that now all filters and post-processors are checked for existence before using them, allowing any exception message for missing filters or post-processors shows all the not found items, instead of the first.

@robfrawley robfrawley added State: Confirmed This item has been confirmed by maintainers as legitimate. Attn: BC Break This issue or PR results in a backwards-compatibility break and therefore requires a major release. Attn: Deprecation This issue or PR results in deprecated functionality. Type: Source Code This item pertains to the source code of this project. labels Mar 9, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Mar 9, 2018
@robfrawley robfrawley merged commit 988d235 into liip:2.0 Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: BC Break This issue or PR results in a backwards-compatibility break and therefore requires a major release. Attn: Deprecation This issue or PR results in deprecated functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Source Code This item pertains to the source code of this project.
Projects
2.x Sprint 001
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant