Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] [CS] Add a required php-cs-fixer build run to Travis matrix #1057

Merged
merged 2 commits into from Mar 2, 2018

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Feb 18, 2018

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #1040
License MIT
Doc PR

This PR provides an implementation of #1049 that adds a requires build of php-cs-fixer to our Travis matrix, enforcing the new code style rules implemented in #1040.

Blocked until #1058 is merged.

@robfrawley robfrawley added State: Confirmed This item has been confirmed by maintainers as legitimate. Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Configuration This item pertains to configuration of this project. Attn: Minor This issue or PR is a minor problem or minor change. labels Feb 18, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Feb 18, 2018
@robfrawley robfrawley changed the title Feature php cs fixer activation [CI] [CS] Add a required php-cs-fixer build run to Travis matrix Feb 18, 2018
@robfrawley robfrawley force-pushed the feature-php-cs-fixer-activation branch from ed28cbd to 0f87bed Compare March 2, 2018 19:06
@robfrawley robfrawley merged commit 3021811 into liip:2.0 Mar 2, 2018
@robfrawley
Copy link
Collaborator Author

Thanks @sebastianblum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Minor This issue or PR is a minor problem or minor change. Level: Enhancement ✨ This item involves an enhancement to existing functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant