Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Remove unused php-cs-fixer from require-dev #1031

Merged
merged 1 commit into from Jan 3, 2018

Conversation

dbu
Copy link
Member

@dbu dbu commented Jan 3, 2018

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? see travis-ci
Fixed tickets -
License MIT
Doc PR -

This dependency is not used since we use styleci instead (which is php-cs-fixer as a service). The cs fixer does not install with PHP 7.3, making the PHP nightly build error.

@dbu
Copy link
Member Author

dbu commented Jan 3, 2018

yay, makes nightly green!

@robfrawley
Copy link
Collaborator

Why was this removed?

This dependency is not used since we use styleci instead.

All contributors and/or collaborators rely on this tool to check our work before committing changes or (in my case) requiring it is run before I accept pull requests. StyleCI is a great check and allows us to express that our code style is sensible via a badge on the README.md, but no one uses its interface to apply patches or otherwise interact with the codebase (in my experience here, anyway). It becomes a nightmare to explain to everyone to install the tool (it's already a pain to get them to even run it, never mind requiring its installation). We should instead use --ignore-platform-reqs on the nightly build.

@dbu
Copy link
Member Author

dbu commented Jan 30, 2018

i was not aware that you use it. i never bother and instead rely on styleci. the build had been broken for a while and this was the easiest way to fix it that i found. i'll quickly do a pr to add it back, ignoring the platform for nightly (which seems a good idea anyways).

@dbu
Copy link
Member Author

dbu commented Jan 30, 2018

see #1045

@robfrawley robfrawley changed the title remove unused php-cs-fixer from require-dev [Dependencies] Remove unused php-cs-fixer from require-dev Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants