Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix tests on Symfony 3.4 and 4.0 #1023

Merged
merged 1 commit into from Dec 12, 2017
Merged

[Tests] Fix tests on Symfony 3.4 and 4.0 #1023

merged 1 commit into from Dec 12, 2017

Conversation

lsmith77
Copy link
Contributor

drop support for all versions below 3.4

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I think we went overboard with the functional tests.
At any rate as a result I made lots of services public, that don't need to be public.

drop support for all versions below 3.4
@robfrawley
Copy link
Collaborator

@lsmith77 Sorry; was away for a bit due to holidays and schedule, but I'll be active again if you need a review moving forward. All the best!

@lsmith77
Copy link
Contributor Author

no need to apologize .. but glad to hear you are back to help .. I have been struggling a bit to find time due to the time spend on the diversity initiative but was also hoping to finally setup the Bundle inside a Symfony 4 sandbox to see what issues remain.

@robfrawley robfrawley changed the title fix tests on Symfony 3.4/4.0 [Tests] Fix tests on Symfony 3.4 and 4.0 Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants