[Dependencies] Enable Symfony 4.0 support #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#SymfonyConHackday2017 |
|
looks good .. will wait until php-enqueue/enqueue-bundle#1 is merged |
|
@lsmith77 It seems that it has been merged now (the PR being this one: php-enqueue/enqueue-dev#269) |
|
@lsmith77 I'll try to check today |
lsmith77
reviewed
Nov 23, 2017
| @@ -36,19 +36,18 @@ | |||
| "doctrine/cache": "~1.1", | |||
| "doctrine/orm": "~2.3", | |||
| "enqueue/enqueue-bundle": "^0.7", | |||
There was a problem hiding this comment.
IIRC for versions below 1.0, we need to explicitly allow minor versions .. so I think this needs to be “^0.7|^0.8” in order to be able to pull in the 0.89 version which provides Symfony compatibility
robfrawley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SymfonyCon Cluj 2017 we add changes to bundles for Symfony 4 support. Also, added changes to composer.json ^4.0 and to .trevis.yml for tests.
#SymfonyConHackDay2017