Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP Configuration #1502

Open
arjanfrans opened this issue Feb 7, 2023 · 1 comment
Open

Support PHP Configuration #1502

arjanfrans opened this issue Feb 7, 2023 · 1 comment

Comments

@arjanfrans
Copy link

Is your feature request related to a problem? Please describe.
I prefer to use a PHP configuration instead of YAML. This doesn't seem to be fully supported.

Describe the solution you'd like
Fix the defintion of the configuration so that it will generate the correct PHP Configuration definitions for Symfony.

Additional context
This is the class that it generates. As you can see, it only allows an empty configuration. I can not set any options under filters in my filter_sets

<?php

namespace Symfony\Config\LiipImagine\FilterSetConfig;

use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;

/**
 * This class is automatically generated to help in creating a config.
 */
class FilterConfig 
{

    public function __construct(array $value = [])
    {
        if ([] !== $value) {
            throw new InvalidConfigurationException(sprintf('The following keys are not supported by "%s": ', __CLASS__).implode(', ', array_keys($value)));
        }
    }

    public function toArray(): array
    {
        $output = [];

        return $output;
    }

}
@dbu
Copy link
Member

dbu commented Feb 17, 2023

agreed that we should support php configuration. i don't have time currently to look into it, but happy to review a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants