Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] issue with gif's #1066

Closed
hjanuschka opened this issue Feb 27, 2018 · 5 comments
Closed

[2.0] issue with gif's #1066

hjanuschka opened this issue Feb 27, 2018 · 5 comments
Labels
State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Dependencies This item pertains to dependencies of this project. Type: Support This item pertains to support for this project.

Comments

@hjanuschka
Copy link
Contributor

Q A
Bug Report? yes
Feature Request? no
BC Break Report? yes
Imagine Bundle Version 2.0-dev

we switched to using 2.0 branch (for symfony 3.4)
and discovered a bug with gif's that do not resize/crop correctly only first frame (using imagick)

looking at imagine/imagine they did a PR: php-imagine/Imagine#481 to fix the issue.

multiple problems, they didn't publish a release yet. and imagine-bundle hard-depends on 0.6.3
to bypass all this, and get our product working again, we now use:

"imagine/imagine": "dev-develop as 0.6.3"

but thats more than hacky, any ideas on how to proceed with that sitation?

@robfrawley
Copy link
Collaborator

robfrawley commented Feb 27, 2018

We don't hard-depend on 0.6.3, instead ^0.6.3 means we accept all patch versions of the library, ie: 0.6.*. This is important as sub-1.0.0 releases allow for breaking changes in minor releases; a 0.7.0 release could break the API while following semvar guidelines.

Once imagine/imagine tag a new release it will be pulled in without any changes to this bundle.

If they tag a new minor release (ie: 0.7.0) we will check to ensure there are no breaking changes and then bump our requirements.

@robfrawley robfrawley added Type: Support This item pertains to support for this project. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Dependencies This item pertains to dependencies of this project. labels Feb 27, 2018
@hjanuschka
Copy link
Contributor Author

@robfrawley thx for fast response. going to stay subscribed to this issue, and post updates if i get news from imagine/imagine 🍺

@hjanuschka
Copy link
Contributor Author

hjanuschka commented Feb 27, 2018

ohhh tbh, they already have v0.7.1 as their latest version, but this one does not yet include the gif patches

@robfrawley
Copy link
Collaborator

robfrawley commented Feb 27, 2018

Justed successfully ran our test suite against ^0.7.1,<0.8 of imagine/imagine and checked the change log for any important merges; looks like it is safe to include in this bundle. PR #1067 will resolve this on our end. Now you have to pester imagine/imagine to tag a release. :-)

@dbu
Copy link
Member

dbu commented Oct 6, 2021

fixed in #1067

@dbu dbu closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Dependencies This item pertains to dependencies of this project. Type: Support This item pertains to support for this project.
Projects
None yet
Development

No branches or pull requests

3 participants