Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move the "simple-phpunit install" command to Travis install section to collapse the output #1048

Merged
merged 1 commit into from Feb 13, 2018

Conversation

dbu
Copy link
Member

@dbu dbu commented Feb 5, 2018

travis-ci shows all output from the script section, but collapses the output of the install section. simple-phpunit uses composer to install the phpunit dependencies, producing a bunch of output that is usually not relevant.

…utput

travis-ci shows all output from the script section, but collapses the output of the install section. simple-phpunit uses composer to install the phpunit dependencies, producing a bunch of output that is usually not relevant.
@sebastianblum
Copy link
Contributor

@dbu I think coverall integration is broken:
it should be if [[ "$ENABLE_CODE_COVERAGE" == "true" && "$TRAVIS_EVENT_TYPE" != "cron" ]]; with == instead of != in the section before_install of .travis.yml

Can you change it or should I open an pr?

@robfrawley
Copy link
Collaborator

@sebastianblum If you don't mind, open a PR. I try to keep PRs focused on their titled purpose, instead of adding other unrelated fixes. If you don't get around to it, I'll take care of it.

@dbu
Copy link
Member Author

dbu commented Feb 12, 2018

thanks.

can we merge this one?

@robfrawley robfrawley changed the title move simple-phpunit installation to install section to collapse the output [CI] Move the "simple-phpunit install" command to Travis install section to collapse the output Feb 13, 2018
@robfrawley robfrawley added State: Confirmed This item has been confirmed by maintainers as legitimate. Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Dependencies This item pertains to dependencies of this project. Type: Configuration This item pertains to configuration of this project. Attn: Minor This issue or PR is a minor problem or minor change. labels Feb 13, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Feb 13, 2018
@robfrawley robfrawley merged commit 1bc459f into 2.0 Feb 13, 2018
@robfrawley
Copy link
Collaborator

Thanks @dbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Minor This issue or PR is a minor problem or minor change. Level: Enhancement ✨ This item involves an enhancement to existing functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project. Type: Dependencies This item pertains to dependencies of this project.
Projects
2.x Sprint 001
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants