Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Revert php-cs-fixer development dependency removal #1045

Merged
merged 1 commit into from Jan 31, 2018

Conversation

dbu
Copy link
Member

@dbu dbu commented Jan 30, 2018

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? => travis
Fixed tickets #1031
License MIT
Doc PR -

adding back the php-cs-fixer as dev dependency because some of the maintainer use it on the cli.

@robfrawley
Copy link
Collaborator

Didn't expect you to make the PR to add it back yourself; much appreciated.

@dbu
Copy link
Member Author

dbu commented Jan 30, 2018

if i go in and mess in your project, i can also clean up after myself ;-)

nightly is green as well , phew.

@robfrawley robfrawley changed the title add php-cs-fixer back in [Deps] Revert php-cs-fixer development dependency removal Jan 31, 2018
@robfrawley robfrawley added State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Dependencies This item pertains to dependencies of this project. Attn: Minor This issue or PR is a minor problem or minor change. labels Jan 31, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Jan 31, 2018
@robfrawley robfrawley merged commit 63e3fad into 2.0 Jan 31, 2018
@robfrawley robfrawley changed the title [Deps] Revert php-cs-fixer development dependency removal [Dependencies] Revert php-cs-fixer development dependency removal Mar 12, 2018
@dbu dbu deleted the php-cs-fixer branch March 18, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Minor This issue or PR is a minor problem or minor change. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Dependencies This item pertains to dependencies of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants