Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Injection] Detect proper web root path based on Symfony kernel version #1044

Merged
merged 1 commit into from Jan 30, 2018

Conversation

robfrawley
Copy link
Collaborator

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1037, #1041, #1042, #1039
License MIT
Doc PR Included

Enable dynamic default configuration values for the following configuration entries:

  • liip_imagine.loaders.<name>.filesystem.data_root
  • liip_imagine.resolvers.<name>.web_path.web_root

The folder layout for the web root directory changed between Symfony 3.x (%kernel.project_dir%/web) and 4.x (%kernel.project_dir%/public). This PR implements an alternate to #1039 as discussed there, where the DI factories dynamically assign the default values based on the Symfony kernel VERSION_ID. All documentation and tests were also amended to accommodate the aforementioned changed.

Additional changes, outside the scope of this titled PR, are:

  • Simplification of the SymfonyFramework::kernelVersionCompare() method implementation.
  • Adding proper type hints to SymfonyFramework.

@robfrawley robfrawley added Attn: Blocker This item blocks other issue(s) or PR(s) and therefore must be resolved prior. Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. Attn: Critical This issue or PR is critical and should be rushed into a new release ASAP. Type: Documentation This item pertains to documentation of this project. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project. Type: Source Code This item pertains to the source code of this project. labels Jan 30, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Jan 30, 2018
@robfrawley robfrawley self-assigned this Jan 30, 2018
@lsmith77
Copy link
Contributor

cool .. yeah I guess we will just keep adding type hints as we touch code for now .. and maybe at some point do a concerted effort. there might be some tools out there that can convert phpdoc to typehints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Blocker This item blocks other issue(s) or PR(s) and therefore must be resolved prior. Attn: Critical This issue or PR is critical and should be rushed into a new release ASAP. Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project. Type: Documentation This item pertains to documentation of this project. Type: Source Code This item pertains to the source code of this project.
Projects
2.x Sprint 001
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants