Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Injection] Change cache manager from private service to public to fix deprecation #1038

Merged
merged 1 commit into from Jan 20, 2018

Conversation

fabianoroberto
Copy link
Contributor

@fabianoroberto fabianoroberto commented Jan 10, 2018

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Fix deprecation in order to call a private service in controller

/** @var CacheManager */
$imagineCacheManager = $this->get('liip_imagine.cache.manager');

Last command is deprecated since Symfony 3.2 and will fail in 4.0

Fix User Deprecated: The "liip_imagine.cache.manager" service is private

@lsmith77 lsmith77 merged commit 4eaf557 into liip:2.0 Jan 20, 2018
@robfrawley robfrawley mentioned this pull request Jan 22, 2018
@robfrawley robfrawley changed the title Fix User Deprecated: The "liip_imagine.cache.manager" service is private [Dependency Injection] Fix User Deprecated: The "liip_imagine.cache.manager" service is private Mar 12, 2018
@robfrawley robfrawley changed the title [Dependency Injection] Fix User Deprecated: The "liip_imagine.cache.manager" service is private [Dependency Injection] Change cache manager from private service to public to fix deprecation Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants