[Dependency Injection] Add alias for cache manager #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without proposed alias, this bundle is not working on Symfony 4.0, and logging a deprecation notice on Symfony 3.4 >Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won't be supported in version 4.0. You should rename (or alias) the "liip_imagine.cache.manager" service to "Liip\ImagineBundle\Imagine\Cache\CacheManager" instead.
|
can you rebase please. |
|
Rebase which branch? |
|
ah sorry .. I guess https://github.com/liip/LiipImagineBundle/pull/1023/files needs to be merged and then rebase against 2.0 |
|
What if you merge this PR and then rebase 1023? |
robfrawley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without proposed alias, this bundle is not working on Symfony 4.0, and logging a deprecation notice on Symfony 3.4