-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnd updatechanpolicy has confusing --help #1523
Comments
You can't have a value of 0 for the CLTV delta. If you did, then you'd be exposed to losing funds on each HTLC you forward, as a race condition is introduced if you ever need to go to the chain for an outgoing HTLC. |
That's the default value for the cli, not
We don't display these values there as it would require |
You don't need to set a value, if you aren't actually modifying it. |
Came here to report the following. Unfortunately, I don't believe you can actually omit the argument:
... if you refer to the lncli help and try to specify the stated default, it won't let you. Perhaps simply update the lncli help to refer to a sane default value of 144? |
agree with ctrlbreak, you can't leave it blank and it tries to prompt you to 0... As an aside, a fee rate of 0.000042 is actually 0.000000000042 satoshis per satoshi sent correct? Am I understanding this correctly? I have mine at 1000, which if I'm correct means I earn 1 satoshi for every 1000 satoshi relayed (ignoring base fee). |
Reopen to properly set the default value. |
Close issue lightningnetwork#1523 - Sane time_lock_delta default
I'd like to add that better documentation around time_lock_delta is sorely needed. |
Still lists 0 as the default that is the confusion I think |
I am interested in picking this one up. It seems to me that if the flag is not set, the value should not be changed, rather than setting a default value for the flag at the CLI level. If this is not what's desired, please let me know. |
I think the confusing default values were removed a while ago. What remains is an inconvenience with the CLI library that we use for One option would be to use |
I opened a PR to fix exactly this. It is very small. Any review is greatly appreciated. |
Some more confusion on help: https://docs.lightning.engineering/lightning-network-tools/lnd/channel-fees suggests that I can update things independently, but I can't. For example, if I just want to update the fee rate with
then if I also add the base fee with
. It seems as though |
Background
lncli updatechanpolicy
states that the default--time_lock_delta
is0
:However:
[lncli] rpc error: code = Unknown desc = time lock delta of 0 is too small, minimum supported is 4
lncli version 0.4.2 commit=a0b2fadea35fa4642daf4e9f56e6ecfe31d22ce1
lncli updatechanpolicy --fee_rate 0.001 --base_fee_msat 100000 --time_lock_delta 0```
Expected behaviour
Unsure
Actual behaviour
Error. See above.
The text was updated successfully, but these errors were encountered: