Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signrpc: update to musig2 0.4.0 #6668

Closed
Roasbeef opened this issue Jun 24, 2022 · 1 comment · Fixed by #6820
Closed

signrpc: update to musig2 0.4.0 #6668

Roasbeef opened this issue Jun 24, 2022 · 1 comment · Fixed by #6820
Labels
crypto Related to the cryptography underlying LND musig2 rpc Related to the RPC interface
Milestone

Comments

@Roasbeef
Copy link
Member

Roasbeef commented Jun 24, 2022

Right now our implementation of musig is fully compliant up until version 0.2.0. Since then, a few changes have been made to nonce generation (which doesn't directly impact the signature generation, and can't fully be verified unless musig-DN is used):

0.5.0 (2022-06-21): Separate ApplyTweak from KeyAgg and introduce KeyGen Context.
0.4.0 (2022-06-20): Allow the output of NonceAgg to be infinity and add test vectors
0.3.2 (2022-06-02): Add a lot of test vectors and improve handling of invalid contributions in reference code.
0.3.1 (2022-05-24): Add NonceGen test vectors
0.3.0 (2022-05-24): Hash i - 1 instead of i in NonceGen
0.2.0 (2022-05-19): Change order of arguments in NonceGen hash function
0.1.0 (2022-05-19): Publication of draft BIP on the bitcoin-dev mailing list  

We should implement the changes to nonce generation, and catch up our set of test vectors.

A PR that catches btcec up to 0.4.0 can be found here: btcsuite/btcd#1865

@Roasbeef Roasbeef added rpc Related to the RPC interface crypto Related to the cryptography underlying LND musig2 labels Jun 24, 2022
@Roasbeef Roasbeef added this to the v0.15.1 milestone Jun 24, 2022
@Roasbeef
Copy link
Member Author

Ok the dependent PR has been merged.

@sputn1ck now we need a PR to lnd that upgrades to the following btcd modules:

  • btcutil/psbt/v1.1.5
  • btcutil/v1.1.2
  • btcec/v2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Related to the cryptography underlying LND musig2 rpc Related to the RPC interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant