forAllOutboundPeers & forAllPeers

[harshjv]

Was taking a look at the source code and found this:

neutrino/neutrino.go

Lines 106 to 121 in e89b367

	// forAllOutboundPeers is a helper function that runs closure on all outbound
	// peers known to peerState.
	func (ps *peerState) forAllOutboundPeers(closure func(sp *ServerPeer)) {
	for _, e := range ps.outboundPeers {
	closure(e)
	}
	for _, e := range ps.persistentPeers {
	closure(e)
	}
	}
	// forAllPeers is a helper function that runs closure on all peers known to
	// peerState.
	func (ps *peerState) forAllPeers(closure func(sp *ServerPeer)) {
	ps.forAllOutboundPeers(closure)
	}

Shouldn't forAllOutboundPeers only apply closure to ps.outboundPeers?

[cfromknecht]

All of neutrino’s peers are outbound at the moment. Persistent just means that we will retry a connection to that peer if we get disconnected.

[cfromknecht]

Naming could probably distinguish better, but I believe the behavior is correct