Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: roll back filter header chain if invalid filter is detected post-sync #218

Open
Roasbeef opened this issue Mar 26, 2021 · 0 comments

Comments

@Roasbeef
Copy link
Member

Recently we improved our verification fo filter headers downloaded as part of #215. As a result of this change, it's possible that a node had an invalid filter header chain that was advertised by all its connected peers (assume they're malicious for the sake of the example). As is, if a peer is running this new commit, and detects an invalid filter from one of their connected peers, then their node will get stuck and won't be able to advanced. What we should do instead is delete the on-disk filter header chain and have it sync from scratch, knowing what the proper element of the chain should be for this newly discovered more valid chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant