New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fee_satoshis
when replying to quick close (as non-opener), not max_fee_satoshis
#3014
Comments
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 23, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 23, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 7, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 9, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fee_satoshis
is the amount they suggest, so you should only respond with a different amount if it's disagreeable.max_fee_satoshis
is the worst case for them, so choosing it is fairly anti-social.The spec does not actually spell this out, unfortunately, but when combined with CLN's "YOLO ignore-fee-rates" option (which sets the feerate to 0xFFFFFFF), the result is stupidly expensive:
ElementsProject/lightning#7242
(And yes, v3 close fixes this, but this is deployed now...)
The text was updated successfully, but these errors were encountered: