Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit htlc_maximum_msat to improve probing-privacy #2984

Open
tnull opened this issue Apr 8, 2024 · 2 comments
Open

Limit htlc_maximum_msat to improve probing-privacy #2984

tnull opened this issue Apr 8, 2024 · 2 comments

Comments

@tnull
Copy link
Contributor

tnull commented Apr 8, 2024

We currently only limit our max_htlc_value_in_flight_msat which we're about to switch off based on announcement status in #2851.

As our anti_probing_penalty_msat penalizes channels that don't set htlc_maximum_msat, we might hence currently penalize some LDK channels in routing by default. We should change ChannelContext::get_announced_htlc_max_msat to also limit the hltc_maximum_msat value based on announcement status.
@tnull tnull mentioned this issue Apr 8, 2024
Draft
@Sharmalm
Copy link
Contributor

Hii, I am working on #2851 can i also try this?

@tnull
Copy link
Contributor Author

tnull commented Apr 22, 2024

Hii, I am working on #2851 can i also try this?

Sure, although it would probably make sense to work sequentially on this, i.e., first finish the previous task before picking this up?

@Sharmalm Sharmalm mentioned this issue Apr 30, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnull @Sharmalm