ddf75afd16 introduced a reachable panic #2982
Milestone
Comments
|
Note that we can ship a beta/rc without this. |
shaavan
added a commit
to shaavan/rust-lightning
that referenced
this issue
Apr 8, 2024
…rocess. 1. When our counterparty disconnects during channel creation, we could have progressed along the channel creation process. 2. In such cases, retrying to send the OpenChannel message would fail because the channel state had progressed, leading to a panic in the `get_open_channel`. 3. To prevent this issue, introduce a new function, `reset_channel_state`, which resets the channel state to its initial state and use it before regenerating the OpenChannel message for an Unfunded Outbound channel. Fixes [lightningdevkit#2982](lightningdevkit#2982) (Identified by the full_stack_target fuzzer)
|
Dropping from 0.0.123, obviously we need to fix this to ship, but we can fix it via #3034 rather than the more full-blown fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Cannot generate an open_channel after we've moved forwardpanic is now reachable as of ddf75af. This isn't on 0.0.121 so we just need to fix it before the next release. Found it through the full_stack_target fuzzer so whoever tackles this please include a "Found by the full_stack_target fuzzer" line at the end of the commit message of the commit that fixes it.The text was updated successfully, but these errors were encountered: