Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink default dust limit #2922

Closed
TheBlueMatt opened this issue Mar 5, 2024 · 6 comments · Fixed by #3045
Closed

Rethink default dust limit #2922

TheBlueMatt opened this issue Mar 5, 2024 · 6 comments · Fixed by #3045
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

It seems the current dust limit (5k * current feerate) is low enough that with a 1sat/vB feerate we may not allow any dust HTLCs at all. Someone should run the math more carefully and we should pick a new default.

@TheBlueMatt TheBlueMatt added this to the 0.0.122 milestone Mar 5, 2024
@tnull
Copy link
Contributor

tnull commented Mar 5, 2024

Isn't this mainly an issue on Signet? Should we start introducing more per-network defaults/settings which would, e.g., also allow us to introduce some (~static) defaults for Testnet? This might improve the interop situation with LND and CLN, which (AFAIK both) set static fee rates on testnet that regularly conflict with our dynamic estimates.

@TheBlueMatt
Copy link
Collaborator Author

Hmm, I mean if feerates ever drop back down to 1 sat/vB on mainnet it would be an issue there as well, I assume. It may be that there's no reasonable value here that scales across feerates (and maybe we need a multiplier + const config, rather than a simple multiplier), but it would be good to run some analysis here that's more rigorous.

@TheBlueMatt
Copy link
Collaborator Author

As for static feerates on testnet, I think we can just do that downstream of LDK? Maybe document it in the estimator? I guess we could add wrappers in Channel when looking at feerates to check if the network is test and accept anything? That's a separate issue, though, IMO.

@tnull
Copy link
Contributor

tnull commented Mar 6, 2024

As for static feerates on testnet, I think we can just do that downstream of LDK? Maybe document it in the estimator? I guess we could add wrappers in Channel when looking at feerates to check if the network is test and accept anything? That's a separate issue, though, IMO.

Yeah, might be a separate issue. But, I think it would be good to either automatically set defaults compatible with what LND/CLN is doing or to at least provide very clear guidance in the docs somewhere, because users keep running into these issues on testnet.

@TheBlueMatt
Copy link
Collaborator Author

Can you open an issue to track it (maybe with some color on how often we see this and in exactly which ways)?

@tnull
Copy link
Contributor

tnull commented Mar 8, 2024

Can you open an issue to track it (maybe with some color on how often we see this and in exactly which ways)?

Done: #2925

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.122, 0.0.123 Mar 18, 2024
@TheBlueMatt TheBlueMatt self-assigned this Mar 21, 2024
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue May 7, 2024
Now that we're including excess counterparty commitment transaction
fees in our dust calculation, we need to update the docs
accordingly. We do so here, describing some of the considerations
and risks that come with the new changes.

We also take this opportunity to double the default value, as users
have regularly complained that non-anchor channels fail to send
HTLCs with the default settings with some feerates.

Fixes lightningdevkit#2922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants